Commit ac9e2d9a authored by Luciano Coelho's avatar Luciano Coelho
Browse files

wl1251: convert 32-bit values to le32 before writing to the chip 



The 32-bit values were not converted before writing them to the chip.
Change the wl1251_read32() and wl1251_write32() so that they always
read and write le32 values and convert to and from the CPU endianess.

Signed-off-by: default avatarLuciano Coelho <coelho@ti.com>
parent 059625e7

drivers/net/wireless/wl1251/io.h

+4 −5
Original line number Original line Diff line number Diff line
@@ -36,16 +36,15 @@ 




static inline u32 wl1251_read32(struct wl1251 *wl, int addr)

static inline u32 wl1251_read32(struct wl1251 *wl, int addr)

{

{

	u32 response;

	wl->if_ops->read(wl, addr, &wl->buffer_32, sizeof(wl->buffer_32));



	wl->if_ops->read(wl, addr, &response, sizeof(u32));





	return response;

	return le32_to_cpu(wl->buffer_32);

}

}





static inline void wl1251_write32(struct wl1251 *wl, int addr, u32 val)

static inline void wl1251_write32(struct wl1251 *wl, int addr, u32 val)

{

{

	wl->if_ops->write(wl, addr, &val, sizeof(u32));

	wl->buffer_32 = cpu_to_le32(val);

	wl->if_ops->write(wl, addr, &wl->buffer_32, sizeof(wl->buffer_32));

}

}





static inline u32 wl1251_read_elp(struct wl1251 *wl, int addr)

static inline u32 wl1251_read_elp(struct wl1251 *wl, int addr)

drivers/net/wireless/wl1251/wl1251.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -380,7 +380,7 @@ struct wl1251 { 
	struct wl1251_stats stats;

	struct wl1251_stats stats;

	struct wl1251_debugfs debugfs;

	struct wl1251_debugfs debugfs;





	u32 buffer_32;

	__le32 buffer_32;

	u32 buffer_cmd;

	u32 buffer_cmd;

	u8 buffer_busyword[WL1251_BUSY_WORD_LEN];

	u8 buffer_busyword[WL1251_BUSY_WORD_LEN];

	struct wl1251_rx_descriptor *rx_descriptor;

	struct wl1251_rx_descriptor *rx_descriptor;