Commit aca6bf54 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab
Browse files

[media] smiapp: Scaling goodness is signed 



The "best" value was unsigned however, leading to signed-to-unsigned
comparison and wrong results. Possibly only on a newer GCC. Fix this by
making the best value signed as well.

Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent e5a3f7b8

drivers/media/i2c/smiapp/smiapp-core.c

+1 −1
Original line number Diff line number Diff line
@@ -1766,7 +1766,7 @@ static void smiapp_set_compose_binner(struct v4l2_subdev *subdev, 
	struct smiapp_sensor *sensor = to_smiapp_sensor(subdev);

	unsigned int i;

	unsigned int binh = 1, binv = 1;

	unsigned int best = scaling_goodness(

	int best = scaling_goodness(

		subdev,

		crops[SMIAPP_PAD_SINK]->width, sel->r.width,

		crops[SMIAPP_PAD_SINK]->height, sel->r.height, sel->flags);