Commit ad36aab3 authored by Yu Zhang's avatar Yu Zhang Committed by Sean Christopherson
Browse files

KVM: nVMX: Remove outdated comments in nested_vmx_setup_ctls_msrs() 



nested_vmx_setup_ctls_msrs() initializes the vmcs_conf.nested,
which stores the global VMX MSR configurations when nested is
supported, regardless of any particular CPUID settings for one
VM.

Commit 6defc591 ("KVM: nVMX: include conditional controls
in /dev/kvm KVM_GET_MSRS") added the some feature flags for
secondary proc-based controls, so that those features can be
available in KVM_GET_MSRS. Yet this commit did not remove the
obsolete comments in nested_vmx_setup_ctls_msrs().

Just fix the comments, and no functional change intended.

Fixes: 6defc591 ("KVM: nVMX: include conditional controls in /dev/kvm KVM_GET_MSRS")
Signed-off-by: default avatarYu Zhang <yu.c.zhang@linux.intel.com>
Link: https://lore.kernel.org/r/20230119141946.585610-1-yu.c.zhang@linux.intel.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent d8708b80

arch/x86/kvm/vmx/nested.c

+0 −5
Original line number Diff line number Diff line
@@ -6866,11 +6866,6 @@ void nested_vmx_setup_ctls_msrs(struct vmcs_config *vmcs_conf, u32 ept_caps) 
	msrs->procbased_ctls_low &=

		~(CPU_BASED_CR3_LOAD_EXITING | CPU_BASED_CR3_STORE_EXITING);



	/*

	 * secondary cpu-based controls.  Do not include those that

	 * depend on CPUID bits, they are added later by

	 * vmx_vcpu_after_set_cpuid.

	 */

	msrs->secondary_ctls_low = 0;



	msrs->secondary_ctls_high = vmcs_conf->cpu_based_2nd_exec_ctrl;