Unverified Commit ad4e8480 authored by Herve Codina's avatar Herve Codina Committed by Mark Brown
Browse files

iio: inkern: Remove the 'unused' variable usage in iio_channel_read_max() 



The code uses a local variable to initialize a null pointer in order to
avoid accessing this null pointer later on.

Simply removed the 'unused' variable and check for the null pointer just
before accessing it.

Signed-off-by: default avatarHerve Codina <herve.codina@bootlin.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/r/20230623085830.749991-6-herve.codina@bootlin.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1e1b4fbd

drivers/iio/inkern.c

+2 −5
Original line number Diff line number Diff line
@@ -849,14 +849,10 @@ static int iio_channel_read_max(struct iio_channel *chan, 
				int *val, int *val2, int *type,

				enum iio_chan_info_enum info)

{

	int unused;

	const int *vals;

	int length;

	int ret;



	if (!val2)

		val2 = &unused;



	ret = iio_channel_read_avail(chan, &vals, type, &length, info);

	if (ret < 0)

		return ret;
@@ -869,6 +865,7 @@ static int iio_channel_read_max(struct iio_channel *chan, 
			break;

		default:

			*val = vals[4];

			if (val2)

				*val2 = vals[5];

		}

		return 0;