Commit af7320ec authored by Yang Li's avatar Yang Li Committed by Lee Jones
Browse files

leds: trigger: netdev: Remove NULL check before dev_{put, hold} 



The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold},
remove it to silence the warnings:

./drivers/leds/trigger/ledtrig-netdev.c:291:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
./drivers/leds/trigger/ledtrig-netdev.c:401:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=4929


Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230511070820.52731-1-yang.lee@linux.alibaba.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 82f80ef5

drivers/leds/trigger/ledtrig-netdev.c

+2 −4
Original line number Diff line number Diff line
@@ -287,7 +287,6 @@ static int netdev_trig_notify(struct notifier_block *nb, 
		trigger_data->carrier_link_up = netif_carrier_ok(dev);

		fallthrough;

	case NETDEV_REGISTER:

		if (trigger_data->net_dev)

		dev_put(trigger_data->net_dev);

		dev_hold(dev);

		trigger_data->net_dev = dev;
@@ -397,7 +396,6 @@ static void netdev_trig_deactivate(struct led_classdev *led_cdev) 


	cancel_delayed_work_sync(&trigger_data->work);



	if (trigger_data->net_dev)

	dev_put(trigger_data->net_dev);



	kfree(trigger_data);