Commit af982da9 authored by YueHaibing's avatar YueHaibing Committed by Steve French
Browse files

cifs: Fix inconsistent IS_ERR and PTR_ERR 



Fix inconsistent IS_ERR and PTR_ERR in cifs_find_swn_reg(). The proper
pointer to be passed as argument to PTR_ERR() is share_name.

This bug was detected with the help of Coccinelle.

Fixes: bf80e5d4 ("cifs: Send witness register and unregister commands to userspace daemon")
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarSamuel Cabrero <scabrero@suse.de>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 03e9bb1a

fs/cifs/cifs_swn.c

+1 −1
Original line number Diff line number Diff line
@@ -272,7 +272,7 @@ static struct cifs_swn_reg *cifs_find_swn_reg(struct cifs_tcon *tcon) 
	if (IS_ERR(share_name)) {

		int ret;



		ret = PTR_ERR(net_name);

		ret = PTR_ERR(share_name);

		cifs_dbg(VFS, "%s: failed to extract share name from target '%s': %d\n",

				__func__, tcon->treeName, ret);

		kfree(net_name);