Commit af9cdf95 authored by Srishti Sharma's avatar Srishti Sharma Committed by Greg Kroah-Hartman
Browse files

Staging: irda: Use !x instead of NULL comparison 



Test for NULL as !x where functions that return NULL on failure
are used. Done using the following semantic patch by coccinelle.

@ is_null @
expression E;
statement S;
@@

E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|
usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...));

(
if(!E)
   S
|
-if(E==NULL)
+if(!E)
    S
)

Signed-off-by: default avatarSrishti Sharma <srishtishar@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bf90447c

drivers/staging/irda/net/discovery.c

+2 −2
Original line number Diff line number Diff line
@@ -179,7 +179,7 @@ void irlmp_expire_discoveries(hashbin_t *log, __u32 saddr, int force) 
				/* Create the client specific buffer */

				n = HASHBIN_GET_SIZE(log);

				buffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC);

				if (buffer == NULL) {

				if (!buffer) {

					spin_unlock_irqrestore(&log->hb_spinlock, flags);

					return;

				}
@@ -291,7 +291,7 @@ struct irda_device_info *irlmp_copy_discoveries(hashbin_t *log, int *pn, 
				/* Create the client specific buffer */

				n = HASHBIN_GET_SIZE(log);

				buffer = kmalloc(n * sizeof(struct irda_device_info), GFP_ATOMIC);

				if (buffer == NULL) {

				if (!buffer) {

					spin_unlock_irqrestore(&log->hb_spinlock, flags);

					return NULL;

				}