Commit b0b7a7d2 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: return back links tw run optimisation 



io_submit_flush_completions() may queue new requests for tw execution,
especially true for linked requests. Recheck the tw list for emptiness
after flushing completions.

Note that this doesn't really fix the commit referenced below, but it
does reinstate an optimization that existed before that got merged.

Fixes: f88262e6 ("io_uring: lockless task list")
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/6328acdbb5e60efc762b18003382de077e6e1367.1673887636.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 88b80534

io_uring/io_uring.c

+4 −1
Original line number Diff line number Diff line
@@ -1344,8 +1344,11 @@ static int __io_run_local_work(struct io_ring_ctx *ctx, bool *locked) 


	if (!llist_empty(&ctx->work_llist))

		goto again;

	if (*locked)

	if (*locked) {

		io_submit_flush_completions(ctx);

		if (!llist_empty(&ctx->work_llist))

			goto again;

	}

	trace_io_uring_local_work_run(ctx, ret, loops);

	return ret;

}