Commit b0f2044c authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: use safe iterator in rtw_acl_remove_sta 



Use list_for_each_entry_safe, we may delete list items while iterating
over the list.

Fixes: 23017c88 ("staging: rtl8188eu: Use list iterators and helpers")
Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20210517201826.25150-4-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 39b19c63

drivers/staging/rtl8188eu/core/rtw_ap.c

+3 −5
Original line number Diff line number Diff line
@@ -1068,8 +1068,8 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr) 


int rtw_acl_remove_sta(struct adapter *padapter, u8 *addr)

{

	struct list_head *plist, *phead;

	struct rtw_wlan_acl_node *paclnode;

	struct list_head *phead;

	struct rtw_wlan_acl_node *paclnode, *temp;

	struct sta_priv *pstapriv = &padapter->stapriv;

	struct wlan_acl_pool *pacl_list = &pstapriv->acl_list;

	struct __queue *pacl_node_q = &pacl_list->acl_node_q;
@@ -1079,9 +1079,7 @@ int rtw_acl_remove_sta(struct adapter *padapter, u8 *addr) 
	spin_lock_bh(&pacl_node_q->lock);



	phead = get_list_head(pacl_node_q);

	list_for_each(plist, phead) {

		paclnode = list_entry(plist, struct rtw_wlan_acl_node, list);



	list_for_each_entry_safe(paclnode, temp, phead, list) {

		if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {

			if (paclnode->valid) {

				paclnode->valid = false;