Commit b1858190 authored by Márton Németh's avatar Márton Németh Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (13414): ttusb-dec: do not overwrite the first part of phys string 

Use strlcat() to append a string to the previously created first part.

The semantic match that finds this kind of problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression dev;
expression phys;
expression str;
expression size;
@@
 	usb_make_path(dev, phys, size);
-	strlcpy(phys, str, size);
+	strlcat(phys, str, size);
// </smpl>

Signed-off-by: default avatarMárton Németh <nm127@freemail.hu>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent cd0e280f

drivers/media/dvb/ttusb-dec/ttusb_dec.c

+1 −1
Original line number Diff line number Diff line
@@ -1198,7 +1198,7 @@ static int ttusb_init_rc( struct ttusb_dec *dec) 
	int err;



	usb_make_path(dec->udev, dec->rc_phys, sizeof(dec->rc_phys));

	strlcpy(dec->rc_phys, "/input0", sizeof(dec->rc_phys));

	strlcat(dec->rc_phys, "/input0", sizeof(dec->rc_phys));



	input_dev = input_allocate_device();

	if (!input_dev)