Commit b1e27239 authored by Dave Chinner's avatar Dave Chinner Committed by Darrick J. Wong
Browse files

xfs: flush data dev on external log write 



We incorrectly flush the log device instead of the data device when
trying to ensure metadata is correctly on disk before writing the
unmount record.

Fixes: eef983ff ("xfs: journal IO cache flush reductions")
Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
parent b102a46c

fs/xfs/xfs_log.c

+1 −1
Original line number Diff line number Diff line
@@ -833,7 +833,7 @@ xlog_write_unmount_record( 
	 * stamp the tail LSN into the unmount record.

	 */

	if (log->l_targ != log->l_mp->m_ddev_targp)

		blkdev_issue_flush(log->l_targ->bt_bdev);

		blkdev_issue_flush(log->l_mp->m_ddev_targp->bt_bdev);

	return xlog_write(log, &vec, ticket, NULL, NULL, XLOG_UNMOUNT_TRANS);

}