Commit b207602f authored by Dan Carpenter's avatar Dan Carpenter Committed by Steve French
Browse files

ksmbd: uninitialized variable in create_socket() 



The "ksmbd_socket" variable is not initialized on this error path.

Cc: stable@vger.kernel.org
Fixes: 0626e664 ("cifsd: add server handler for central processing and tranport layers")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 2fd5dcb1

fs/ksmbd/transport_tcp.c

+2 −1
Original line number Diff line number Diff line
@@ -404,7 +404,7 @@ static int create_socket(struct interface *iface) 
				  &ksmbd_socket);

		if (ret) {

			pr_err("Can't create socket for ipv4: %d\n", ret);

			goto out_error;

			goto out_clear;

		}



		sin.sin_family = PF_INET;
@@ -462,6 +462,7 @@ static int create_socket(struct interface *iface) 


out_error:

	tcp_destroy_socket(ksmbd_socket);

out_clear:

	iface->ksmbd_socket = NULL;

	return ret;

}