Commit b26113fa authored by Markus Elfring's avatar Markus Elfring Committed by Takashi Iwai
Browse files

ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs() 



Omit extra messages for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

[Fixed the unused variable warning by this change as well -- tiwai]

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: default avatarDaniel Mack <daniel@zonque.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9ecb2406

sound/usb/caiaq/audio.c

+0 −3
Original line number Diff line number Diff line
@@ -722,7 +722,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) 
	int i, frame;

	struct urb **urbs;

	struct usb_device *usb_dev = cdev->chip.dev;

	struct device *dev = caiaqdev_to_dev(cdev);

	unsigned int pipe;



	pipe = (dir == SNDRV_PCM_STREAM_PLAYBACK) ?
@@ -731,7 +730,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) 


	urbs = kmalloc(N_URBS * sizeof(*urbs), GFP_KERNEL);

	if (!urbs) {

		dev_err(dev, "unable to kmalloc() urbs, OOM!?\n");

		*ret = -ENOMEM;

		return NULL;

	}
@@ -746,7 +744,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) 
		urbs[i]->transfer_buffer =

			kmalloc(FRAMES_PER_URB * BYTES_PER_FRAME, GFP_KERNEL);

		if (!urbs[i]->transfer_buffer) {

			dev_err(dev, "unable to kmalloc() transfer buffer, OOM!?\n");

			*ret = -ENOMEM;

			return urbs;

		}