Commit b3462009 authored by Jonathan Cameron's avatar Jonathan Cameron Committed by Dmitry Torokhov
Browse files

Input: mtk-pmic-keys - switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() 



SIMPLE_DEV_PM_OPS() is deprecated as it requires explicit protection
against unused function warnings.  The new combination of pm_sleep_ptr()
and DEFINE_SIMPLE_DEV_PM_OPS() allows the compiler to see the functions,
thus suppressing the warning, but still allowing the unused code to be
removed. Thus also drop the __maybe_unused markings.

Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarMattijs Korpershoek <mkorpershoek@baylibre.com>
Link: https://lore.kernel.org/r/20221204180841.2211588-10-jic23@kernel.org


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 8362cb5c

drivers/input/keyboard/mtk-pmic-keys.c

+5 −5
Original line number Diff line number Diff line
@@ -231,7 +231,7 @@ static int mtk_pmic_key_setup(struct mtk_pmic_keys *keys, 
	return 0;

}



static int __maybe_unused mtk_pmic_keys_suspend(struct device *dev)

static int mtk_pmic_keys_suspend(struct device *dev)

{

	struct mtk_pmic_keys *keys = dev_get_drvdata(dev);

	int index;
@@ -247,7 +247,7 @@ static int __maybe_unused mtk_pmic_keys_suspend(struct device *dev) 
	return 0;

}



static int __maybe_unused mtk_pmic_keys_resume(struct device *dev)

static int mtk_pmic_keys_resume(struct device *dev)

{

	struct mtk_pmic_keys *keys = dev_get_drvdata(dev);

	int index;
@@ -263,7 +263,7 @@ static int __maybe_unused mtk_pmic_keys_resume(struct device *dev) 
	return 0;

}



static SIMPLE_DEV_PM_OPS(mtk_pmic_keys_pm_ops, mtk_pmic_keys_suspend,

static DEFINE_SIMPLE_DEV_PM_OPS(mtk_pmic_keys_pm_ops, mtk_pmic_keys_suspend,

				mtk_pmic_keys_resume);



static const struct of_device_id of_mtk_pmic_keys_match_tbl[] = {
@@ -387,7 +387,7 @@ static struct platform_driver pmic_keys_pdrv = { 
	.driver = {

		   .name = "mtk-pmic-keys",

		   .of_match_table = of_mtk_pmic_keys_match_tbl,

		   .pm = &mtk_pmic_keys_pm_ops,

		   .pm = pm_sleep_ptr(&mtk_pmic_keys_pm_ops),

	},

};