Commit b3ca7aff authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

intel: thermal: PCH: Drop ACPI_FADT_LOW_POWER_S0 check 



If ACPI_FADT_LOW_POWER_S0 is not set, this doesn't mean that low-power
S0 idle is not usable.  It merely means that using S3 on the given
system is more beneficial from the energy saving perspective than using
low-power S0 idle, as long as S3 is supported.

Suspend-to-idle is still a valid suspend mode if ACPI_FADT_LOW_POWER_S0
is not set and the pm_suspend_via_firmware() check in pch_wpt_suspend()
is sufficient to distinguish suspend-to-idle from S3, so drop the
confusing ACPI_FADT_LOW_POWER_S0 check.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarZhang Rui <rui.zhang@intel.com>
parent 06d9fb48

drivers/thermal/intel/intel_pch_thermal.c

+0 −8
Original line number Diff line number Diff line
@@ -207,14 +207,6 @@ static int pch_wpt_suspend(struct pch_thermal_device *ptd) 
		return 0;

	}



	/* Do not check temperature if it is not a S0ix capable platform */

#ifdef CONFIG_ACPI

	if (!(acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0))

		return 0;

#else

	return 0;

#endif



	/* Do not check temperature if it is not s2idle */

	if (pm_suspend_via_firmware())

		return 0;