Commit b452ee00 authored by Brendan Jackman's avatar Brendan Jackman Committed by Alexei Starovoitov
Browse files

docs: bpf: Clarify -mcpu=v3 requirement for atomic ops 

Alexei pointed out [1] that this wording is pretty confusing. Here's
an attempt to be more explicit and clear.

[1] https://lore.kernel.org/bpf/CAADnVQJVvwoZsE1K+6qRxzF7+6CvZNzygnoBW9tZNWJELk5c=Q@mail.gmail.com/



Signed-off-by: default avatarBrendan Jackman <jackmanb@google.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20210120133946.2107897-3-jackmanb@google.com
parent 53fe5418

Documentation/networking/filter.rst

+4 −3
Original line number Diff line number Diff line
@@ -1081,9 +1081,10 @@ before is loaded back to ``R0``. 


Note that 1 and 2 byte atomic operations are not supported.



Except ``BPF_ADD`` *without* ``BPF_FETCH`` (for legacy reasons), all 4 byte

atomic operations require alu32 mode. Clang enables this mode by default in

architecture v3 (``-mcpu=v3``). For older versions it can be enabled with

Clang can generate atomic instructions by default when ``-mcpu=v3`` is

enabled. If a lower version for ``-mcpu`` is set, the only atomic instruction

Clang can generate is ``BPF_ADD`` *without* ``BPF_FETCH``. If you need to enable

the atomics features, while keeping a lower ``-mcpu`` version, you can use

``-Xclang -target-feature -Xclang +alu32``.



You may encounter ``BPF_XADD`` - this is a legacy name for ``BPF_ATOMIC``,