Commit b4e1882d authored by Fabio Aiuto's avatar Fabio Aiuto Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: remove HAL_{BB,MAC,RF,FW}_ENABLE macros 



remove HAL_{BB,MAC,RF,FW}_ENABLE macros.
They are used to turn on/off by hand some core
capabilities we want to be always 'on'.

So remove usages and definitions.

Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/04248acbd22f9be30d21891926e134490b34036a.1623756906.git.fabioaiuto83@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bb1c456d

drivers/staging/rtl8723bs/hal/sdio_halinit.c

+0 −6
Original line number Diff line number Diff line
@@ -683,29 +683,23 @@ static u32 rtl8723bs_hal_init(struct adapter *padapter) 
	/*  <Roger_Notes> Current Channel will be updated again later. */

	pHalData->CurrentChannel = 6;



#if (HAL_MAC_ENABLE == 1)

	ret = PHY_MACConfig8723B(padapter);

	if (ret != _SUCCESS)

		return ret;

#endif

	/*  */

	/* d. Initialize BB related configurations. */

	/*  */

#if (HAL_BB_ENABLE == 1)

	ret = PHY_BBConfig8723B(padapter);

	if (ret != _SUCCESS)

		return ret;

#endif



	/*  If RF is on, we need to init RF. Otherwise, skip the procedure. */

	/*  We need to follow SU method to change the RF cfg.txt. Default disable RF TX/RX mode. */

	/* if (pHalData->eRFPowerState == eRfOn) */

	{

#if (HAL_RF_ENABLE == 1)

		ret = PHY_RFConfig8723B(padapter);

		if (ret != _SUCCESS)

			return ret;

#endif

	}



	/*  */

drivers/staging/rtl8723bs/include/autoconf.h

+0 −4
Original line number Diff line number Diff line
@@ -12,7 +12,3 @@ 
 * Auto Config Section

 */

#define LPS_RPWM_WAIT_MS 300
 


#define HAL_MAC_ENABLE	1

#define HAL_BB_ENABLE	1

#define HAL_RF_ENABLE	1

drivers/staging/rtl8723bs/include/hal_phy.h

+0 −8
Original line number Diff line number Diff line
@@ -6,14 +6,6 @@ 
 ******************************************************************************/

#ifndef __HAL_PHY_H__

#define __HAL_PHY_H__





/*  FPGA_PHY and ASIC */

#define	HAL_FW_ENABLE	1

#define	HAL_MAC_ENABLE	1

#define	HAL_BB_ENABLE	1

#define	HAL_RF_ENABLE	1



/*  */

/*  Antenna detection method, i.e., using single tone detection or RSSI reported from each antenna detected. */

/*  Added by Roger, 2013.05.22. */