Commit b5ea08d8 authored by Michael Straube's avatar Michael Straube Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: refactor rtw_usb_bulk_size_boundary() 



Using ternary operator to set a variable to true or false is not
needed. Convert two such uses of ternary operator in
rtw_usb_bulk_size_boundary() to just use the condition and return the
value directly instead of using a return variable. This shortens the
code and improves readability. While at it, remove an unneeded line
break from the function head.

Signed-off-by: default avatarMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220329103756.6740-2-straube.linux@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 38238ecb

drivers/staging/r8188eu/include/usb_ops.h

+3 −8
Original line number Diff line number Diff line
@@ -47,19 +47,14 @@ static inline void rtw_reset_continual_urb_error(struct dvobj_priv *dvobj) 
#define USB_HIGH_SPEED_BULK_SIZE	512

#define USB_FULL_SPEED_BULK_SIZE	64



static inline u8 rtw_usb_bulk_size_boundary(struct adapter *padapter,

					    int buf_len)

static inline u8 rtw_usb_bulk_size_boundary(struct adapter *padapter, int buf_len)

{

	u8 rst = true;

	struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter);



	if (pdvobjpriv->pusbdev->speed == USB_SPEED_HIGH)

		rst = (0 == (buf_len) % USB_HIGH_SPEED_BULK_SIZE) ?

		      true : false;

		return buf_len % USB_HIGH_SPEED_BULK_SIZE == 0;

	else

		rst = (0 == (buf_len) % USB_FULL_SPEED_BULK_SIZE) ?

		      true : false;

	return rst;

		return buf_len % USB_FULL_SPEED_BULK_SIZE == 0;

}



#endif /* __USB_OPS_H_ */