Commit b622ffe1 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS: NFSv2/v3 clients should never be setting NFS_CAP_XATTR 



Ensure that we always initialise the 'xattr_support' field in struct
nfs_fsinfo, so that nfs_server_set_fsinfo() doesn't declare our NFSv2/v3
client to be capable of supporting the NFSv4.2 xattr protocol by setting
the NFS_CAP_XATTR capability.

This configuration can cause nfs_do_access() to set access mode bits
that are unsupported by the NFSv3 ACCESS call, which may confuse
spec-compliant servers.

Reported-by: default avatarOlga Kornievskaia <kolga@netapp.com>
Fixes: b78ef845 ("NFSv4.2: query the server for extended attribute support")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent 41e97b7f

fs/nfs/nfs3xdr.c

+1 −0
Original line number Diff line number Diff line
@@ -2228,6 +2228,7 @@ static int decode_fsinfo3resok(struct xdr_stream *xdr, 
	/* ignore properties */

	result->lease_time = 0;

	result->change_attr_type = NFS4_CHANGE_TYPE_IS_UNDEFINED;

	result->xattr_support = 0;

	return 0;

}

fs/nfs/proc.c

+1 −0
Original line number Diff line number Diff line
@@ -92,6 +92,7 @@ nfs_proc_get_root(struct nfs_server *server, struct nfs_fh *fhandle, 
	info->maxfilesize = 0x7FFFFFFF;

	info->lease_time = 0;

	info->change_attr_type = NFS4_CHANGE_TYPE_IS_UNDEFINED;

	info->xattr_support = 0;

	return 0;

}