Commit b6b03b86 authored by Ricardo Koller's avatar Ricardo Koller Committed by Marc Zyngier
Browse files

KVM: selftests: Add missing close and munmap in __vm_mem_region_delete() 



Deleting a memslot (when freeing a VM) is not closing the backing fd,
nor it's unmapping the alias mapping. Fix by adding the missing close
and munmap.

Reviewed-by: default avatarAndrew Jones <andrew.jones@linux.dev>
Reviewed-by: default avatarOliver Upton <oupton@google.com>
Reviewed-by: default avatarBen Gardon <bgardon@google.com>
Signed-off-by: default avatarRicardo Koller <ricarkol@google.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221017195834.2295901-4-ricarkol@google.com
parent 228f324d

tools/testing/selftests/kvm/lib/kvm_util.c

+6 −0
Original line number Diff line number Diff line
@@ -586,6 +586,12 @@ static void __vm_mem_region_delete(struct kvm_vm *vm, 
	sparsebit_free(&region->unused_phy_pages);

	ret = munmap(region->mmap_start, region->mmap_size);

	TEST_ASSERT(!ret, __KVM_SYSCALL_ERROR("munmap()", ret));

	if (region->fd >= 0) {

		/* There's an extra map when using shared memory. */

		ret = munmap(region->mmap_alias, region->mmap_size);

		TEST_ASSERT(!ret, __KVM_SYSCALL_ERROR("munmap()", ret));

		close(region->fd);

	}



	free(region);

}