Commit b7be130c authored by Florian Fainelli's avatar Florian Fainelli Committed by Jakub Kicinski
Browse files

net: dsa: bcm_sf2: Fix Wake-on-LAN with mac_link_down() 



After commit 2d1f90f9 ("net: dsa/bcm_sf2: fix incorrect usage of
state->link") the interface suspend path would call our mac_link_down()
call back which would forcibly set the link down, thus preventing
Wake-on-LAN packets from reaching our management port.

Fix this by looking at whether the port is enabled for Wake-on-LAN and
not clearing the link status in that case to let packets go through.

Fixes: 2d1f90f9 ("net: dsa/bcm_sf2: fix incorrect usage of state->link")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220512021731.2494261-1-f.fainelli@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 810c2f0a

drivers/net/dsa/bcm_sf2.c

+3 −0
Original line number Diff line number Diff line
@@ -809,6 +809,9 @@ static void bcm_sf2_sw_mac_link_down(struct dsa_switch *ds, int port, 
	struct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds);

	u32 reg, offset;



	if (priv->wol_ports_mask & BIT(port))

		return;



	if (port != core_readl(priv, CORE_IMP0_PRT_ID)) {

		if (priv->type == BCM4908_DEVICE_ID ||

		    priv->type == BCM7445_DEVICE_ID)