Commit b7ec2061 authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: do not submit NEW_ADDR to read node block 



After the below patch, give cp is errored, we drop dirty node pages. This
can give NEW_ADDR to read node pages. Don't do WARN_ON() which gives
generic/475 failure.

Fixes: 28607bf3 ("f2fs: drop dirty node pages when cp is in error status")
Reviewed-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 7eab7a69

fs/f2fs/node.c

+2 −1
Original line number Diff line number Diff line
@@ -1330,7 +1330,8 @@ static int read_node_page(struct page *page, int op_flags) 
	if (err)

		return err;



	if (unlikely(ni.blk_addr == NULL_ADDR) ||

	/* NEW_ADDR can be seen, after cp_error drops some dirty node pages */

	if (unlikely(ni.blk_addr == NULL_ADDR || ni.blk_addr == NEW_ADDR) ||

			is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN)) {

		ClearPageUptodate(page);

		return -ENOENT;