Commit b859c579 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Alex Deucher
Browse files

drm/amd/display: Fix 32-bit divide error in wait_for_alt_mode 



When building arm32 allyesconfig:

ld.lld: error: undefined symbol: __aeabi_uldivmod
>>> referenced by dc_link.c
>>> gpu/drm/amd/display/dc/core/dc_link.o:(wait_for_alt_mode) in archive drivers/built-in.a
>>> referenced by dc_link.c
>>> gpu/drm/amd/display/dc/core/dc_link.o:(wait_for_alt_mode) in archive drivers/built-in.a

time_taken_in_ns is of type unsigned long long so we need to use div_u64
to avoid this error.

Fixes: b5b1f455 ("drm/amd/display: Enable type C hotplug")
Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 5a6a4c9d

drivers/gpu/drm/amd/display/dc/core/dc_link.c

+2 −2
Original line number Diff line number Diff line
@@ -721,7 +721,7 @@ bool wait_for_alt_mode(struct dc_link *link) 
			time_taken_in_ns = dm_get_elapse_time_in_ns(

				link->ctx, finish_timestamp, enter_timestamp);

			DC_LOG_WARNING("Alt mode entered finished after %llu ms\n",

				       time_taken_in_ns / 1000000);

				       div_u64(time_taken_in_ns, 1000000));

			return true;

		}
@@ -730,7 +730,7 @@ bool wait_for_alt_mode(struct dc_link *link) 
	time_taken_in_ns = dm_get_elapse_time_in_ns(link->ctx, finish_timestamp,

						    enter_timestamp);

	DC_LOG_WARNING("Alt mode has timed out after %llu ms\n",

			time_taken_in_ns / 1000000);

			div_u64(time_taken_in_ns, 1000000));

	return false;

}