Commit b873d103 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix mbuf pool resource detected as busy at driver unload 

In a situation where the node state changes while a REG_LOGIN is in
progress, the LPFC_MBOXQ_t structure is cleared and reused for an
UNREG_LOGIN command to release RPI resources without first freeing the mbuf
pool resource allocated for REG_LOGIN.

Release mbuf pool resource prior to repurposing of the mailbox command
structure from REG_LOGIN to UNREG_LOGIN.

Link: https://lore.kernel.org/r/20220911221505.117655-4-jsmart2021@gmail.com


Co-developed-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 11d6583d

drivers/scsi/lpfc/lpfc_sli.c

+7 −0
Original line number Diff line number Diff line
@@ -2856,6 +2856,7 @@ void 
lpfc_sli_def_mbox_cmpl(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)

{

	struct lpfc_vport  *vport = pmb->vport;

	struct lpfc_dmabuf *mp;

	struct lpfc_nodelist *ndlp;

	struct Scsi_Host *shost;

	uint16_t rpi, vpi;
@@ -2868,6 +2869,12 @@ lpfc_sli_def_mbox_cmpl(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb) 
	if (!(phba->pport->load_flag & FC_UNLOADING) &&

	    pmb->u.mb.mbxCommand == MBX_REG_LOGIN64 &&

	    !pmb->u.mb.mbxStatus) {

		mp = (struct lpfc_dmabuf *)pmb->ctx_buf;

		if (mp) {

			pmb->ctx_buf = NULL;

			lpfc_mbuf_free(phba, mp->virt, mp->phys);

			kfree(mp);

		}

		rpi = pmb->u.mb.un.varWords[0];

		vpi = pmb->u.mb.un.varRegLogin.vpi;

		if (phba->sli_rev == LPFC_SLI_REV4)