Commit b90cd197 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: set @poll->file after @poll init 



It's a good practice to modify fields of a struct after but not before
it was initialised. Even though io_init_poll_iocb() doesn't touch
poll->file, call it first.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 24c74678

fs/io_uring.c

+1 −1
Original line number Diff line number Diff line
@@ -4596,8 +4596,8 @@ static __poll_t __io_arm_poll_handler(struct io_kiocb *req, 
	struct io_ring_ctx *ctx = req->ctx;

	bool cancel = false;



	poll->file = req->file;

	io_init_poll_iocb(poll, mask, wake_func);

	poll->file = req->file;

	poll->wait.private = req;



	ipt->pt._key = mask;