Commit ba2f1293 authored by Daniel Wagner's avatar Daniel Wagner Committed by Martin K. Petersen
Browse files

scsi: sym53c8xx_2: Use complete() instead complete_all() 



There is only one waiter for the completion, therefore there is no need
to use complete_all(). Let's make that clear by using complete() instead
of complete_all().

The usage pattern of the completion is:

waiter context                          waker context

sym_eh_handler()
  struct completion eh_done
  init_completion(eh_done)
  pci_channel_offline()
  wait_for_completion_timeout(eh_done)

                                        sym2_io_resume()
                                          complete(eh_done)

Signed-off-by: default avatarDaniel Wagner <daniel.wagner@bmw-carit.de>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3e3f5a8a

drivers/scsi/sym53c8xx_2/sym_glue.c

+1 −1
Original line number Diff line number Diff line
@@ -1874,7 +1874,7 @@ static void sym2_io_resume(struct pci_dev *pdev) 


	spin_lock_irq(shost->host_lock);

	if (sym_data->io_reset)

		complete_all(sym_data->io_reset);

		complete(sym_data->io_reset);

	spin_unlock_irq(shost->host_lock);

}