Commit ba6856aa authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: Simplify v4l2_fh_open() error handling 



v4l2_fh_open() can only fail with -ENOMEM and as a generic rule drivers
do not log their own errors for -ENOMEM since the kernel will already
have complained loudly about this before the -ENOMEM return.

Remove the unnecessary error logging from atomisp_open().

Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 5b9853ad

drivers/staging/media/atomisp/pci/atomisp_fops.c

+1 −5
Original line number Diff line number Diff line
@@ -708,12 +708,8 @@ static int atomisp_open(struct file *file) 
	dev_dbg(isp->dev, "open device %s\n", vdev->name);



	ret = v4l2_fh_open(file);

	if (ret) {

		dev_err(isp->dev,

			"%s: v4l2_fh_open() returned error %d\n",

		       __func__, ret);

	if (ret)

		return ret;

	}



	rt_mutex_lock(&isp->mutex);