Commit bae7c690 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

greybus: remove redundant latency-tag sanity checks 



Core will never call host-device callbacks with invalid arguments (and
that would still need to be verified in bridge firmware anyway), so
remove the redundant and insufficient sanity check from the callbacks.

Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent ae36e81e

drivers/staging/greybus/es2.c

+0 −10
Original line number Diff line number Diff line
@@ -622,11 +622,6 @@ static int latency_tag_enable(struct gb_host_device *hd, u16 cport_id) 
	struct es2_ap_dev *es2 = hd_to_es2(hd);

	struct usb_device *udev = es2->usb_dev;



	if (!cport_id_valid(hd, cport_id)) {

		dev_err(&udev->dev, "invalid cport %u\n", cport_id);

		return -EINVAL;

	}



	retval = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),

				 GB_APB_REQUEST_LATENCY_TAG_EN,

				 USB_DIR_OUT | USB_TYPE_VENDOR |
@@ -645,11 +640,6 @@ static int latency_tag_disable(struct gb_host_device *hd, u16 cport_id) 
	struct es2_ap_dev *es2 = hd_to_es2(hd);

	struct usb_device *udev = es2->usb_dev;



	if (!cport_id_valid(hd, cport_id)) {

		dev_err(&udev->dev, "invalid cport %u\n", cport_id);

		return -EINVAL;

	}



	retval = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),

				 GB_APB_REQUEST_LATENCY_TAG_DIS,

				 USB_DIR_OUT | USB_TYPE_VENDOR |