Commit bb4d15df authored by Wolfram Sang's avatar Wolfram Sang Committed by Jakub Kicinski
Browse files

vlan: move from strlcpy with unused retval to strscpy 

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/


Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20220818210204.8275-1-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent cdb27b7b

net/8021q/vlan_dev.c

+3 −3
Original line number Diff line number Diff line
@@ -674,9 +674,9 @@ static int vlan_ethtool_get_link_ksettings(struct net_device *dev, 
static void vlan_ethtool_get_drvinfo(struct net_device *dev,

				     struct ethtool_drvinfo *info)

{

	strlcpy(info->driver, vlan_fullname, sizeof(info->driver));

	strlcpy(info->version, vlan_version, sizeof(info->version));

	strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));

	strscpy(info->driver, vlan_fullname, sizeof(info->driver));

	strscpy(info->version, vlan_version, sizeof(info->version));

	strscpy(info->fw_version, "N/A", sizeof(info->fw_version));

}



static int vlan_ethtool_get_ts_info(struct net_device *dev,