Commit bbc3925c authored by luo penghao's avatar luo penghao Committed by Jens Axboe
Browse files

cdrom: Remove redundant variable and its assignment 



Variable is not used in functions, and its assignment is redundant too.
So it should be deleted. Also the inner-most set of parentheses is no
longer needed.

The clang_analyzer complains as follows:

drivers/cdrom/cdrom.c:877: warning:

Although the value stored to 'ret' is used in the enclosing expression,
the value is never actually read from 'ret'.

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarluo penghao <luo.penghao@zte.com.cn>
Link: https://lore.kernel.org/all/20211020024229.1036219-1-luo.penghao@zte.com.cn


Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20211021074621.901-1-phil@philpotter.co.uk


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9c03fee7

drivers/cdrom/cdrom.c

+2 −2
Original line number Diff line number Diff line
@@ -871,7 +871,7 @@ static void cdrom_mmc3_profile(struct cdrom_device_info *cdi) 
{

	struct packet_command cgc;

	char buffer[32];

	int ret, mmc3_profile;

	int mmc3_profile;



	init_cdrom_command(&cgc, buffer, sizeof(buffer), CGC_DATA_READ);
@@ -881,7 +881,7 @@ static void cdrom_mmc3_profile(struct cdrom_device_info *cdi) 
	cgc.cmd[8] = sizeof(buffer);		/* Allocation Length */

	cgc.quiet = 1;



	if ((ret = cdi->ops->generic_packet(cdi, &cgc)))

	if (cdi->ops->generic_packet(cdi, &cgc))

		mmc3_profile = 0xffff;

	else

		mmc3_profile = (buffer[6] << 8) | buffer[7];