Commit bd550173 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: refactor io_wake_function 



Remove a local variable ctx in io_wake_function(), we don't need it if
io_should_wake() triggers it to wake up.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/e60eb1008aebe286aab7d34c772ed01c447bddb1.1673274244.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent dde40322

io_uring/io_uring.c

+2 −4
Original line number Diff line number Diff line
@@ -2439,15 +2439,13 @@ static inline bool io_should_wake(struct io_wait_queue *iowq) 
static int io_wake_function(struct wait_queue_entry *curr, unsigned int mode,

			    int wake_flags, void *key)

{

	struct io_wait_queue *iowq = container_of(curr, struct io_wait_queue,

							wq);

	struct io_ring_ctx *ctx = iowq->ctx;

	struct io_wait_queue *iowq = container_of(curr, struct io_wait_queue, wq);



	/*

	 * Cannot safely flush overflowed CQEs from here, ensure we wake up

	 * the task, and the next invocation will do it.

	 */

	if (io_should_wake(iowq) || io_has_work(ctx))

	if (io_should_wake(iowq) || io_has_work(iowq->ctx))

		return autoremove_wake_function(curr, mode, wake_flags, key);

	return -1;

}