Commit bd8bf77f authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans Verkuil
Browse files

media: meson-ir-tx: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent ea4e628f

drivers/media/rc/meson-ir-tx.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -372,13 +372,11 @@ static int __init meson_irtx_probe(struct platform_device *pdev) 
	return 0;

	return 0;

}

}





static int meson_irtx_remove(struct platform_device *pdev)

static void meson_irtx_remove(struct platform_device *pdev)

{

{

	struct rc_dev *rc = platform_get_drvdata(pdev);

	struct rc_dev *rc = platform_get_drvdata(pdev);





	rc_unregister_device(rc);

	rc_unregister_device(rc);



	return 0;

}

}





static const struct of_device_id meson_irtx_dt_match[] = {

static const struct of_device_id meson_irtx_dt_match[] = {
@@ -390,7 +388,7 @@ static const struct of_device_id meson_irtx_dt_match[] = { 
MODULE_DEVICE_TABLE(of, meson_irtx_dt_match);

MODULE_DEVICE_TABLE(of, meson_irtx_dt_match);





static struct platform_driver meson_irtx_pd = {

static struct platform_driver meson_irtx_pd = {

	.remove = meson_irtx_remove,

	.remove_new = meson_irtx_remove,

	.driver = {

	.driver = {

		.name = DRIVER_NAME,

		.name = DRIVER_NAME,

		.of_match_table = meson_irtx_dt_match,

		.of_match_table = meson_irtx_dt_match,