Commit be35ae9e authored by Santiago Leon's avatar Santiago Leon Committed by David S. Miller
Browse files

ibmveth: Return -EINVAL on all ->probe errors 



We had a few cases where we returned success on error.

Signed-off-by: default avatarAnton Blanchard <anton@samba.org>
Signed-off-by: default avatarSantiago Leon <santil@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f148f61d

drivers/net/ibmveth.c

+2 −2
Original line number Diff line number Diff line
@@ -1392,7 +1392,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, 
							NULL);

	if (!mac_addr_p) {

		dev_err(&dev->dev, "Can't find VETH_MAC_ADDR attribute\n");

		return 0;

		return -EINVAL;

	}



	mcastFilterSize_p = (unsigned int *)vio_get_attribute(dev,
@@ -1400,7 +1400,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, 
	if (!mcastFilterSize_p) {

		dev_err(&dev->dev, "Can't find VETH_MCAST_FILTER_SIZE "

			"attribute\n");

		return 0;

		return -EINVAL;

	}



	netdev = alloc_etherdev(sizeof(struct ibmveth_adapter));