Commit bf7f7efb authored by Andrey Strachuk's avatar Andrey Strachuk Committed by Alex Deucher
Browse files

drm/amdgpu: remove useless condition in amdgpu_job_stop_all_jobs_on_sched() 



Local variable 'rq' is initialized by an address
of field of drm_sched_job, so it does not make
sense to compare 'rq' with NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Reviewed-by: default avatarAndrey Grodzovsky <andrey.grodzovsky@amd.com>
Signed-off-by: default avatarAndrey Strachuk <strochuk@ispras.ru>
Fixes: 7c6e68c7 ("drm/amdgpu: Avoid HW GPU reset for RAS.")
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1af9add1

drivers/gpu/drm/amd/amdgpu/amdgpu_job.c

+0 −4
Original line number Diff line number Diff line
@@ -272,10 +272,6 @@ void amdgpu_job_stop_all_jobs_on_sched(struct drm_gpu_scheduler *sched) 
	/* Signal all jobs not yet scheduled */

	for (i = DRM_SCHED_PRIORITY_COUNT - 1; i >= DRM_SCHED_PRIORITY_MIN; i--) {

		struct drm_sched_rq *rq = &sched->sched_rq[i];



		if (!rq)

			continue;



		spin_lock(&rq->lock);

		list_for_each_entry(s_entity, &rq->entities, list) {

			while ((s_job = to_drm_sched_job(spsc_queue_pop(&s_entity->job_queue)))) {