Commit bf8e56bf authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: sock_bindtodevice() RCU-ification 



Avoid dev_hold()/dev_put() in sock_bindtodevice()

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 69df9d59

net/core/sock.c

+6 −4
Original line number Diff line number Diff line
@@ -420,14 +420,16 @@ static int sock_bindtodevice(struct sock *sk, char __user *optval, int optlen) 
	if (devname[0] == '\0') {

		index = 0;

	} else {

		struct net_device *dev = dev_get_by_name(net, devname);

		struct net_device *dev;



		rcu_read_lock();

		dev = dev_get_by_name_rcu(net, devname);

		if (dev)

			index = dev->ifindex;

		rcu_read_unlock();

		ret = -ENODEV;

		if (!dev)

			goto out;



		index = dev->ifindex;

		dev_put(dev);

	}



	lock_sock(sk);