Commit bf9f80cf authored Oct 08, 2019 by Johannes Berg Committed by Richard Weinberger Nov 25, 2019

um: virtio_uml: Disallow modular build



This driver *can* be a module, but then its parameters (socket path)
are untrusted data from inside the VM, and that isn't allowed. Allow
the code to only be built-in to avoid that.

Fixes: 5d38f324 ("um: drivers: Add virtio vhost-user driver")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.co.uk>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent 7e607460

arch/um/drivers/Kconfig

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -337,7 +337,7 @@ config UML_NET_SLIRP
	endmenu		endmenu

	config VIRTIO_UML		config VIRTIO_UML
	tristate "UML driver for virtio devices"		bool "UML driver for virtio devices"
	select VIRTIO		select VIRTIO
	help		help
	This driver provides support for virtio based paravirtual device		This driver provides support for virtio based paravirtual device

arch/um/drivers/virtio_uml.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -4,12 +4,12 @@
	*		*
	* Copyright(c) 2019 Intel Corporation		* Copyright(c) 2019 Intel Corporation
	*		*
	* This module allows virtio devices to be used over a vhost-user socket.		* This driver allows virtio devices to be used over a vhost-user socket.
	*		*
	* Guest devices can be instantiated by kernel module or command line		* Guest devices can be instantiated by kernel module or command line
	* parameters. One device will be created for each parameter. Syntax:		* parameters. One device will be created for each parameter. Syntax:
	*		*
	* [virtio_uml.]device=<socket>:<virtio_id>[:<platform_id>]		* virtio_uml.device=<socket>:<virtio_id>[:<platform_id>]
	* where:		* where:
	* <socket> := vhost-user socket path to connect		* <socket> := vhost-user socket path to connect
	* <virtio_id> := virtio device id (as in virtio_ids.h)		* <virtio_id> := virtio device id (as in virtio_ids.h)