Commit c03ff66d authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

usb: pci-quirks: Reduce the length of a spinlock section in usb_amd_find_chipset_info() 



'info' is local to the function. There is no need to zeroing it within
a spin_lock section. Moreover, there is no need to explicitly initialize
the .need_pll_quirk field.

Initialize the structure when defined and remove the now useless memset().

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/08ee42fced6af6bd56892cd14f2464380ab071fa.1679600396.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent df9ba6a2

drivers/usb/host/pci-quirks.c

+1 −3
Original line number Diff line number Diff line
@@ -207,8 +207,7 @@ EXPORT_SYMBOL_GPL(sb800_prefetch); 
static void usb_amd_find_chipset_info(void)

{

	unsigned long flags;

	struct amd_chipset_info info;

	info.need_pll_quirk = false;

	struct amd_chipset_info info = { };



	spin_lock_irqsave(&amd_lock, flags);
@@ -218,7 +217,6 @@ static void usb_amd_find_chipset_info(void) 
		spin_unlock_irqrestore(&amd_lock, flags);

		return;

	}

	memset(&info, 0, sizeof(info));

	spin_unlock_irqrestore(&amd_lock, flags);



	if (!amd_chipset_sb_type_init(&info)) {