Commit c22f7f5b authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove Efuse_PgPacketWrite_BT function 



Remove static Efuse_PgPacketWrite_BT and its one caller from
core/rtw_efuse.c. This function is a wrapper function which calls
the Efuse_PgPacketWrite_BT function pointer of struct hal_ops
unconditionally. As this function pointer is never set, and this
function call is possible to reach, this could lead to an attempt to
deference a NULL pointer, which would crash the driver.

Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210906010106.898-12-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 54ff2ed4

drivers/staging/r8188eu/core/rtw_efuse.c

+1 −12
Original line number Diff line number Diff line
@@ -351,15 +351,6 @@ int Efuse_PgPacketWrite(struct adapter *pAdapter, u8 offset, u8 word_en, u8 *dat 
	return ret;

}



static int Efuse_PgPacketWrite_BT(struct adapter *pAdapter, u8 offset, u8 word_en, u8 *data, bool pseudo)

{

	int ret;



	ret =  pAdapter->HalFunc.Efuse_PgPacketWrite_BT(pAdapter, offset, word_en, data, pseudo);



	return ret;

}



/*-----------------------------------------------------------------------------

 * Function:	efuse_WordEnableDataRead

 *
@@ -676,8 +667,6 @@ u8 rtw_BT_efuse_map_write(struct adapter *padapter, u16 addr, u16 cnts, u8 *data 
				DBG_88E("0x%02X ", newdata[i]);

			DBG_88E("\n");



			ret = Efuse_PgPacketWrite_BT(padapter, offset, word_en, newdata, false);

			if (ret == _FAIL)

			break;

		}