Commit c29429f3 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

ASoC: tlv320dac33: Add guarding parentheses to macros 



Put parentheses around macro argument uses. This avoids pitfalls
for the programmer, where the argument expansion does not give the
expected result, for example:

SAMPLES_TO_US(substream->runtime->rate, dac33->uthr - DAC33_MODE7_MARGIN + 1);

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent a8fdac83

sound/soc/codecs/tlv320dac33.c

+3 −3
Original line number Diff line number Diff line
@@ -55,13 +55,13 @@ 
#define BURST_BASEFREQ_HZ	49152000



#define SAMPLES_TO_US(rate, samples) \

	(1000000000 / ((rate * 1000) / samples))

	(1000000000 / (((rate) * 1000) / (samples)))



#define US_TO_SAMPLES(rate, us) \

	(rate / (1000000 / (us < 1000000 ? us : 1000000)))

	((rate) / (1000000 / ((us) < 1000000 ? (us) : 1000000)))



#define UTHR_FROM_PERIOD_SIZE(samples, playrate, burstrate) \

	((samples * 5000) / ((burstrate * 5000) / (burstrate - playrate)))

	(((samples)*5000) / (((burstrate)*5000) / ((burstrate) - (playrate))))



static void dac33_calculate_times(struct snd_pcm_substream *substream);

static int dac33_prepare_chip(struct snd_pcm_substream *substream);