Unverified Commit c524f167 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

ASoC: Intel: sst: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-94-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0d31e8ad

sound/soc/intel/atom/sst/sst_acpi.c

+2 −3
Original line number Diff line number Diff line
@@ -335,14 +335,13 @@ static int sst_acpi_probe(struct platform_device *pdev) 
* This function is called by OS when a device is unloaded

* This frees the interrupt etc

*/

static int sst_acpi_remove(struct platform_device *pdev)

static void sst_acpi_remove(struct platform_device *pdev)

{

	struct intel_sst_drv *ctx;



	ctx = platform_get_drvdata(pdev);

	sst_context_cleanup(ctx);

	platform_set_drvdata(pdev, NULL);

	return 0;

}



static const struct acpi_device_id sst_acpi_ids[] = {
@@ -360,7 +359,7 @@ static struct platform_driver sst_acpi_driver = { 
		.pm			= &intel_sst_pm,

	},

	.probe	= sst_acpi_probe,

	.remove	= sst_acpi_remove,

	.remove_new = sst_acpi_remove,

};



module_platform_driver(sst_acpi_driver);