Commit c52d270c authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Alexandre Belloni
Browse files

rtc: s3c: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20200830080937.14367-1-krzk@kernel.org
parent 0d982de3

drivers/rtc/rtc-s3c.c

+2 −7
Original line number Diff line number Diff line
@@ -494,13 +494,8 @@ static int s3c_rtc_probe(struct platform_device *pdev) 
	if (info->data->needs_src_clk) {

		info->rtc_src_clk = devm_clk_get(&pdev->dev, "rtc_src");

		if (IS_ERR(info->rtc_src_clk)) {

			ret = PTR_ERR(info->rtc_src_clk);

			if (ret != -EPROBE_DEFER)

				dev_err(&pdev->dev,

			ret = dev_err_probe(&pdev->dev, PTR_ERR(info->rtc_src_clk),

					    "failed to find rtc source clock\n");

			else

				dev_dbg(&pdev->dev,

					"probe deferred due to missing rtc src clk\n");

			goto err_src_clk;

		}

		ret = clk_prepare_enable(info->rtc_src_clk);