Commit c5662498 authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Greg Kroah-Hartman
Browse files

Staging: hv: Get rid of blkvsc_mutex 



The blkvsc_mutex is unnecessary as the state it is protecting
(blkdev->users) is already protected by the spin lock.

Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarAbhishek Kane <v-abkane@microsoft.com>
Signed-off-by: default avatarHank Janssen <hjanssen@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent ca8f3525

drivers/staging/hv/blkvsc_drv.c

+0 −5
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ 
#include <linux/major.h>

#include <linux/delay.h>

#include <linux/hdreg.h>

#include <linux/mutex.h>

#include <linux/slab.h>

#include <scsi/scsi.h>

#include <scsi/scsi_cmnd.h>
@@ -113,8 +112,6 @@ struct block_device_context { 
	int users;

};



static DEFINE_MUTEX(blkvsc_mutex);



static const char *g_blk_driver_name = "blkvsc";



/* {32412632-86cb-44a2-9b5c-50d1417354f5} */
@@ -620,7 +617,6 @@ static int blkvsc_release(struct gendisk *disk, fmode_t mode) 
{

	struct block_device_context *blkdev = disk->private_data;



	mutex_lock(&blkvsc_mutex);

	spin_lock(&blkdev->lock);

	if (blkdev->users == 1) {

		spin_unlock(&blkdev->lock);
@@ -631,7 +627,6 @@ static int blkvsc_release(struct gendisk *disk, fmode_t mode) 
	blkdev->users--;



	spin_unlock(&blkdev->lock);

	mutex_unlock(&blkvsc_mutex);

	return 0;

}