Commit c60bd968 authored Apr 12, 2022 by Bjorn Andersson Committed by Wolfram Sang Apr 15, 2022

i2c: qcom-geni: Use dev_err_probe() for GPI DMA error



The GPI DMA engine driver can be compiled as a module, in which case the
likely probe deferral "error" shows up in the kernel log. Switch to
using dev_err_probe() to silence this warning and to ensure that
"devices_deferred" in debugfs carries this information.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>

parent 39c02572

drivers/i2c/busses/i2c-qcom-geni.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -843,10 +843,8 @@ static int geni_i2c_probe(struct platform_device *pdev)
		/* FIFO is disabled, so we can only use GPI DMA */
		gi2c->gpi_mode = true;
		ret = setup_gpi_dma(gi2c);
		if (ret) {
		dev_err(dev, "Failed to setup GPI DMA mode:%d ret\n", ret);
		return ret;
		}
		if (ret)
		return dev_err_probe(dev, ret, "Failed to setup GPI DMA mode\n");

		dev_dbg(dev, "Using GPI DMA mode for I2C\n");
		} else {