Commit c6d41f66 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Hans de Goede
Browse files

platform/surface: Switch to use acpi_evaluate_dsm_typed() 



The acpi_evaluate_dsm_typed() provides a way to check the type of the
object evaluated by _DSM call. Use it instead of open coded variant.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20230118093823.39679-1-andriy.shevchenko@linux.intel.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent b09ee1cd

drivers/platform/surface/surface_hotplug.c

+3 −10
Original line number Diff line number Diff line
@@ -101,18 +101,12 @@ static void shps_dsm_notify_irq(struct platform_device *pdev, enum shps_irq_type 
	param.type = ACPI_TYPE_INTEGER;

	param.integer.value = value;



	result = acpi_evaluate_dsm(handle, &shps_dsm_guid, SHPS_DSM_REVISION,

				   shps_dsm_fn_for_irq(type), &param);



	result = acpi_evaluate_dsm_typed(handle, &shps_dsm_guid, SHPS_DSM_REVISION,

					 shps_dsm_fn_for_irq(type), &param, ACPI_TYPE_BUFFER);

	if (!result) {

		dev_err(&pdev->dev, "IRQ notification via DSM failed (irq=%d, gpio=%d)\n",

			type, value);



	} else if (result->type != ACPI_TYPE_BUFFER) {

		dev_err(&pdev->dev,

			"IRQ notification via DSM failed: unexpected result type (irq=%d, gpio=%d)\n",

			type, value);



	} else if (result->buffer.length != 1 || result->buffer.pointer[0] != 0) {

		dev_err(&pdev->dev,

			"IRQ notification via DSM failed: unexpected result value (irq=%d, gpio=%d)\n",
@@ -121,7 +115,6 @@ static void shps_dsm_notify_irq(struct platform_device *pdev, enum shps_irq_type 


	mutex_unlock(&sdev->lock[type]);



	if (result)

	ACPI_FREE(result);

}