Commit c6d64a19 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

greybus: connection: drop the connection_mutex 



Drop the useless connection_mutex that did not, and can not be used to
prevent connection lookup races in atomic context and therefore serves
no purpose.

Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent c3681f6c

drivers/staging/greybus/connection.c

+1 −5
Original line number Diff line number Diff line
@@ -66,8 +66,6 @@ void greybus_data_rcvd(struct gb_host_device *hd, u16 cport_id, 
}

EXPORT_SYMBOL_GPL(greybus_data_rcvd);



static DEFINE_MUTEX(connection_mutex);



static void gb_connection_kref_release(struct kref *kref)

{

	struct gb_connection *connection;
@@ -75,7 +73,6 @@ static void gb_connection_kref_release(struct kref *kref) 
	connection = container_of(kref, struct gb_connection, kref);



	kfree(connection);

	mutex_unlock(&connection_mutex);

}



static void gb_connection_init_name(struct gb_connection *connection)
@@ -519,8 +516,7 @@ void gb_connection_destroy(struct gb_connection *connection) 
	ida_simple_remove(id_map, connection->hd_cport_id);

	connection->hd_cport_id = CPORT_ID_BAD;



	kref_put_mutex(&connection->kref, gb_connection_kref_release,

		       &connection_mutex);

	kref_put(&connection->kref, gb_connection_kref_release);

}



void gb_connection_latency_tag_enable(struct gb_connection *connection)