Commit c77a78c2 authored by John Garry's avatar John Garry Committed by Arnaldo Carvalho de Melo
Browse files

tools build: Enable warnings through HOSTCFLAGS 



The tools build system uses KBUILD_HOSTCFLAGS symbol for obvious purposes.

However this is not set for anything under tools/

As such, host tools apps built have no compiler warnings enabled.

Declare HOSTCFLAGS for perf tools build, and also use that symbol in
declaration of host_c_flags. HOSTCFLAGS comes from EXTRA_WARNINGS, which
is independent of target platform/arch warning flags.

Suggested-by: default avatarJiri Olsa <jolsa@redhat.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Laura Abbott <labbott@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/1635525041-151876-1-git-send-email-john.garry@huawei.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent e9c08f72

tools/build/Build.include

+1 −1
Original line number Diff line number Diff line
@@ -99,7 +99,7 @@ cxx_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(CXXFLAGS) -D"BUILD_STR(s)=\#s" $(CXX 
###

## HOSTCC C flags



host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(KBUILD_HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj))

host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj))



# output directory for tests below

TMPOUT = .tmp_$$$$

tools/perf/Makefile.config

+5 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ detected = $(shell echo "$(1)=y" >> $(OUTPUT).config-detected) 
detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)



CFLAGS := $(EXTRA_CFLAGS) $(filter-out -Wnested-externs,$(EXTRA_WARNINGS))

HOSTCFLAGS := $(filter-out -Wnested-externs,$(EXTRA_WARNINGS))



include $(srctree)/tools/scripts/Makefile.arch
@@ -211,6 +212,7 @@ endif 
ifneq ($(WERROR),0)

  CORE_CFLAGS += -Werror

  CXXFLAGS += -Werror

  HOSTCFLAGS += -Werror

endif



ifndef DEBUG
@@ -290,6 +292,9 @@ CXXFLAGS += -ggdb3 
CXXFLAGS += -funwind-tables

CXXFLAGS += -Wno-strict-aliasing



HOSTCFLAGS += -Wall

HOSTCFLAGS += -Wextra



# Enforce a non-executable stack, as we may regress (again) in the future by

# adding assembler files missing the .GNU-stack linker note.

LDFLAGS += -Wl,-z,noexecstack

tools/perf/Makefile.perf

+1 −1
Original line number Diff line number Diff line
@@ -226,7 +226,7 @@ else 
endif



export srctree OUTPUT RM CC CXX LD AR CFLAGS CXXFLAGS V BISON FLEX AWK

export HOSTCC HOSTLD HOSTAR

export HOSTCC HOSTLD HOSTAR HOSTCFLAGS



include $(srctree)/tools/build/Makefile.include