Commit c7b205fb authored by Jianglei Nie's avatar Jianglei Nie Committed by David S. Miller
Browse files

net: macsec: fix potential resource leak in macsec_add_rxsa() and macsec_add_txsa() 



init_rx_sa() allocates relevant resource for rx_sa->stats and rx_sa->
key.tfm with alloc_percpu() and macsec_alloc_tfm(). When some error
occurs after init_rx_sa() is called in macsec_add_rxsa(), the function
released rx_sa with kfree() without releasing rx_sa->stats and rx_sa->
key.tfm, which will lead to a resource leak.

We should call macsec_rxsa_put() instead of kfree() to decrease the ref
count of rx_sa and release the relevant resource if the refcount is 0.
The same bug exists in macsec_add_txsa() for tx_sa as well. This patch
fixes the above two bugs.

Fixes: 3cf3227a ("net: macsec: hardware offloading infrastructure")
Signed-off-by: default avatarJianglei Nie <niejianglei2021@163.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 20a85461

drivers/net/macsec.c

+2 −2
Original line number Diff line number Diff line
@@ -1844,7 +1844,7 @@ static int macsec_add_rxsa(struct sk_buff *skb, struct genl_info *info) 
	return 0;



cleanup:

	kfree(rx_sa);

	macsec_rxsa_put(rx_sa);

	rtnl_unlock();

	return err;

}
@@ -2087,7 +2087,7 @@ static int macsec_add_txsa(struct sk_buff *skb, struct genl_info *info) 


cleanup:

	secy->operational = was_operational;

	kfree(tx_sa);

	macsec_txsa_put(tx_sa);

	rtnl_unlock();

	return err;

}