Commit c8332236 authored Jul 11, 2018 by Colin Ian King Committed by Greg Kroah-Hartman Jul 11, 2018

staging: comedi: remove redundant variable segpos



Variable segpos is being assigned but is never used hence it is redundant
and can be removed.

Cleans up clang warning:
warning: variable 'segpos' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 75971225

drivers/staging/comedi/drivers/pcl816.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -282,7 +282,7 @@ static int check_channel_list(struct comedi_device *dev,
		unsigned int chanlen)
		{
		unsigned int chansegment[16];
		unsigned int i, nowmustbechan, seglen, segpos;
		unsigned int i, nowmustbechan, seglen;

		/* correct channel and range number check itself comedi/range.c */
		if (chanlen < 1) {
		@@ -312,7 +312,7 @@ static int check_channel_list(struct comedi_device *dev,
		}

		/* check whole chanlist */
		for (i = 0, segpos = 0; i < chanlen; i++) {
		for (i = 0; i < chanlen; i++) {
		if (chanlist[i] != chansegment[i % seglen]) {
		dev_dbg(dev->class_dev,
		"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",

drivers/staging/comedi/drivers/pcl818.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -573,7 +573,7 @@ static int check_channel_list(struct comedi_device *dev,
		unsigned int *chanlist, unsigned int n_chan)
		{
		unsigned int chansegment[16];
		unsigned int i, nowmustbechan, seglen, segpos;
		unsigned int i, nowmustbechan, seglen;

		/* correct channel and range number check itself comedi/range.c */
		if (n_chan < 1) {
		@@ -605,7 +605,7 @@ static int check_channel_list(struct comedi_device *dev,
		}

		/* check whole chanlist */
		for (i = 0, segpos = 0; i < n_chan; i++) {
		for (i = 0; i < n_chan; i++) {
		if (chanlist[i] != chansegment[i % seglen]) {
		dev_dbg(dev->class_dev,
		"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",