Commit c88a15d9 authored by Yang Yingliang's avatar Yang Yingliang Committed by Suzuki K Poulose
Browse files

coresight: tpda: fix return value check in tpda_probe() 



devm_ioremap_resource() never returns NULL pointer, it
will return ERR_PTR() when it fails, so replace the check
with IS_ERR().

Fixes: 5b791662 ("Coresight: Add TPDA link driver")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
[ Fix return value to the PTR_ERR(base) ]
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230129084246.537694-1-yangyingliang@huawei.com
parent 0c1ccc15

drivers/hwtracing/coresight/coresight-tpda.c

+2 −2
Original line number Diff line number Diff line
@@ -145,8 +145,8 @@ static int tpda_probe(struct amba_device *adev, const struct amba_id *id) 
	dev_set_drvdata(dev, drvdata);



	base = devm_ioremap_resource(dev, &adev->res);

	if (!base)

		return -ENOMEM;

	if (IS_ERR(base))

		return PTR_ERR(base);

	drvdata->base = base;



	spin_lock_init(&drvdata->spinlock);