Commit c8be681f authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

staging: csr: fix possible memory leak in do_patch_convert_download() 

pfw has been allocated in function xbv_to_patch() and should be
freed before leaving from the error handling cases.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 37905ae1

drivers/staging/csr/csr_wifi_hip_download.c

+2 −0
Original line number Diff line number Diff line
@@ -250,6 +250,7 @@ static CsrResult do_patch_convert_download(card_t *card, void *dlpriv, xbv1_t *p 
        if (r != CSR_RESULT_SUCCESS)

        {

            unifi_error(card->ospriv, "Failed to find BOOT_LOADER_CONTROL\n");

            kfree(pfw);

            return CSR_RESULT_FAILURE;

        }
@@ -265,6 +266,7 @@ static CsrResult do_patch_convert_download(card_t *card, void *dlpriv, xbv1_t *p 
        desc = unifi_fw_open_buffer(card->ospriv, pfw, psize);

        if (!desc)

        {

            kfree(pfw);

            return CSR_WIFI_HIP_RESULT_NO_MEMORY;

        }